19 Jul
2007
19 Jul
'07
5:34 p.m.
Nicolas Ballas <ballas(a)lrde.epita.fr> writes:
https://svn.lrde.epita.fr/svn/oln/trunk/milena
Index: ChangeLog
from Nicolas Ballas <ballas(a)lrde.epita.fr>
Repair lineary pixel iterator.
``Lineary'' is not an English word. You probably wanted to say
``linear'' (« linéaire ») here.
* mln/core/pixter2d_b.hh: Adapt pixter2d_b to the new
pixel iterator hierachy.
* mln/core/internal/pixel_iterator_base.hh: Fix dead code.
* mln/core/internal/lineary_pixel_iterator_base.hh: New factorization class.
Hey! Don't forget to wrap lines longer than 80 columns, especially in
ChangeLogs where its easier to do (compared to a C++ file with long
identifiers or type names).
(Remember that changes in ChangeLogs shall not create ChangeLog
entries; bypass Vcs or svn-wrapper to avoid side effects.)
[...]
Index:
mln/core/internal/lineary_pixel_iterator_base.hh
--- mln/core/internal/lineary_pixel_iterator_base.hh (revision 0)
+++ mln/core/internal/lineary_pixel_iterator_base.hh (revision 0)
[...]
+ protected:
+ /// beginning of the image
+ value* start_;
+ /// end of the image
+ value* eoi_;
+
+ /// Constructor
+ lineary_pixel_iterator_base_(I& image);
It's better to start comments with a capital letter and end them with
a full stop (period).
Otherwise, seems good!